Re: [PATCH v6 1/5] usb: gadget: pxa27x_udc: prepare device-tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Sep 22, 2014 at 07:38:20PM +0200, Robert Jarzmik wrote:
> Felipe Balbi <balbi@xxxxxx> writes:
> 
> > On Sat, Sep 20, 2014 at 01:38:50PM +0200, Robert Jarzmik wrote:
> >> Felipe Balbi <balbi@xxxxxx> writes:
> >> 
> >> > Hi,
> >> >
> >> > On Fri, Sep 19, 2014 at 10:48:25PM +0200, Robert Jarzmik wrote:
> >> >> Felipe Balbi <balbi@xxxxxx> writes:
> >> >> 
> >> >> > On Fri, Sep 19, 2014 at 09:46:22PM +0200, Robert Jarzmik wrote:
> >> >> >> Since v5: This new patch, split out of the first DT patch
> >> >> >
> >> >> > please resend once v3.18-rc1 is out. But...
> >> >> There are 2 -rc left for v3.17, can't this serie make it for 3.18
> >> >> merge window ?
> >> >
> >> > not anymore. My tree is already closed for v3.18. A bit early, yeah, but
> >> > I'm busy with other stuff.
> >> So be it.
> >> 
> >> > oh, it can definitely be on this series. Just make it patch one.
> >> No thanks, for another time.
> >
> > I insist
> 
> If you "insist", then convince me why this is technicaly needed so that my
> commit message is not "Felipe insists".

"Felipe insists" is fine.

sarcasm aside, gpio descs will look far better as you won't need e.g.:

	if (foo->gpio_is_active_low)
		gpio_set_value(foo->gpio, 0);
	else
		gpio_set_value(foo->gpio, 1);

you get that for free from the gpio descriptor themselves. If you're
already working on the driver, might as well get that done otherwise
people with HW to test things vanish and I'm left with a driver I don't
know whether it works or not.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux