Re: [PATCH v6 1/5] usb: gadget: pxa27x_udc: prepare device-tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Sep 19, 2014 at 09:46:22PM +0200, Robert Jarzmik wrote:
> The pxa27x_udc should support 2 modes of initialization :
>  - one through legacy platform data
>  - one new through device-tree
> 
> Prepare the double support by moving the initialization data, ie. the
> gpios, into the udc control structure.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
> 
> ---
> Since v5: This new patch, split out of the first DT patch

please resend once v3.18-rc1 is out. But...

> -		if (gpio_is_valid(udc->mach->gpio_pullup))
> -			gpio_set_value(udc->mach->gpio_pullup,
> -				       !udc->mach->gpio_pullup_inverted);
> -		if (udc->mach->udc_command)
> +		if (gpio_is_valid(udc->gpio_pullup))

you might want to add a patch converting to gpio_desc

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux