[ added linux-kernel ML to cc: ]
Hi,
On Tuesday, August 26, 2014 11:19:53 AM dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote:
> From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
>
> Move the "samsung,s3c6400-hsotg" binding as the probe function in the gadget
> driver will get removed when the dual-role driver is implemented.
Sorry but no. In the current form this just breaks gadget support for
Samsung devices as probe function for gadget will no longer be called.
[ This should be done in the same patch that aggregates gadget and host
initializations into one driver. ]
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
> Acked-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> ---
> drivers/usb/dwc2/gadget.c | 1 -
> drivers/usb/dwc2/platform.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 94f7a3f..8c45b4c 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -3674,7 +3674,6 @@ static int s3c_hsotg_resume(struct platform_device *pdev)
>
> #ifdef CONFIG_OF
> static const struct of_device_id s3c_hsotg_of_ids[] = {
> - { .compatible = "samsung,s3c6400-hsotg", },
> { .compatible = "snps,dwc2", },
> { /* sentinel */ }
> };
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index 5f0c4bb..dd2f8f5 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -100,6 +100,7 @@ static int dwc2_driver_remove(struct platform_device *dev)
> static const struct of_device_id dwc2_of_match_table[] = {
> { .compatible = "brcm,bcm2835-usb", .data = ¶ms_bcm2835 },
> { .compatible = "snps,dwc2", .data = NULL },
> + { .compatible = "samsung,s3c6400-hsotg", .data = NULL},
> {},
> };
> MODULE_DEVICE_TABLE(of, dwc2_of_match_table);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
