On 09/09/2014 02:06 PM, Paul Zimmerman wrote: >> From: Dinh Nguyen [mailto:dinguyen@xxxxxxxxxxxxxxxxxxxxx] >> Sent: Tuesday, September 09, 2014 9:26 AM >> >> On 09/08/2014 05:50 PM, Greg KH wrote: >>> On Tue, Aug 26, 2014 at 11:19:54AM -0500, dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote: >>>> From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx> >>>> >>>> Adds the gadget data structure and appropriate data structure pointers >>>> to the common dwc2_hsotg data structure. To keep the driver data >>>> dereference code looking clean, the gadget variable declares are only available >>>> for peripheral and dual-role mode. This is needed so that the dwc2_hsotg data >>>> structure can be used by the hcd and gadget drivers. >>>> >>>> Updates gadget.c to use the dwc2_hsotg data structure and gadget pointers >>>> that have been moved into the common dwc2_hsotg structure. Along >>>> with the updating the gadget driver to use the common dwc2_hsotg structure, >>>> a few other things are required in order for this patch to build properly. >>>> Those are: >>>> >>>> - Remove gadget module defines. Since the driver probing will be handled >>>> by either the platform or pci code. >>>> - Change the gadget probe function into gadget_init. >>>> >>>> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx> >>>> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> >>>> --- >>>> v3: Updated with paulz's suggestion to avoid double pointers. >>>> v2: Left the function parameter name as 'hsotg' and just changed its type. >>>> --- >>>> drivers/usb/dwc2/core.h | 176 +++++++++++++++++++++--------------- >>>> drivers/usb/dwc2/gadget.c | 226 +++++++++++++++++----------------------------- >>>> drivers/usb/dwc2/hcd.h | 10 -- >>>> 3 files changed, 184 insertions(+), 228 deletions(-) >>> >>> This doesn't apply as I couldn't take the patches you depended on here >>> :( >>> >>> Can you work with Paul to get this into a series that I can take? >>> >>> Paul, you can just take it and resend it with any previous patches that >>> are needed as well. >>> >> >> This patch series was based on top of "Robert Baldyga : usb: >> dwc2/gadget: fix series <- 12 patches". It looks like that series is not >> in Greg's tree yet. Let me know if you need me to rework that series >> without Robert Baldyga's patches. > > Robert is currently respinning that series, so I suggest you wait for > that to be applied, and then rebase on top of it. > Will do... BTW..Did you get a chance to review patches 9/12 and 12/12 of this series regarding the spinlock placement? thanks, Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
