Re: [PATCH RESEND v3 12/12] usb: dwc2/gadget: avoid disabling ep0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 04, 2014 at 12:04:34PM -0700, Paul Zimmerman wrote:
> From: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> 
> Endpoint 0 should not be disabled, so we start loop counter from number 1.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>

Looks like this would fix a modprobe -r followed by modprobe of dwc2 ?
In that case, should you Cc stable ?

Reviewed-by: Felipe Balbi <balbi@xxxxxx>

> ---
>  drivers/usb/dwc2/gadget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 32af626..94f7a3f 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2929,7 +2929,7 @@ static int s3c_hsotg_udc_stop(struct usb_gadget *gadget,
>  		return -ENODEV;
>  
>  	/* all endpoints should be shutdown */
> -	for (ep = 0; ep < hsotg->num_of_eps; ep++)
> +	for (ep = 1; ep < hsotg->num_of_eps; ep++)
>  		s3c_hsotg_ep_disable(&hsotg->eps[ep].ep);
>  
>  	spin_lock_irqsave(&hsotg->lock, flags);
> -- 
> 2.1.0.24.g4109c28
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux