Re: [PATCH] usb: usbip: fix usbip.h path in userspace tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 04, 2014 at 11:59:40AM +0300, Valentina Manea wrote:
> On Thu, Sep 4, 2014 at 2:41 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Shouldn't you be able to use the same "path" as ch9.h uses?  It's a uapi
> > .h file, no relative paths should be needed.
> >
> 
> For the userspace tool, the build system only looks for headers in the
> system default locations, such as /usr/include. Hence, this won't work
> for systems that don't have kernel 3.17 headers.

That's fine to depend on.

> This patch is a pretty nasty hack to get it to compile within the
> kernel tree.  I wonder whether we can make this self-contained by
> duplicating the header's content inside usbip_common.h.

Ick, no, don't do that, use the .h file, that is what it is there for.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux