On Thu, 4 Sep 2014, Peter Chen wrote: > > > > Hi Greg & Alan, any comments for this patchset? > > > > > > In patch 2/6, why did you move the !is_targeted(udev) code from > > > usb_enumerate_device_otg() to usb_enumerate_device()? Why not leave > > > the code where it is? > > > > > > > TPL support is also needed for embedded host, not only otg host. But usb_enumerate_device_otg() gets called for all types of host, right? At least, it gets called whenever usb_enumerate_device() runs. Yes, it contains "#ifdef CONFIG_USB_OTG". But your patch has "if (... && IS_ENABLED(CONFIG_USB_OTG))", so the behavior is the same. Why move the code if there's no change in behavior? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
