On Wed, 3 Sep 2014, Peter Chen wrote: > > PS: I also have an old patch that adds a reset callback to > > g-mass-storage. Peter asked for this around the same time the other > > work was done. The idea was that disconnect must flush the buffers to > > the backing storage device, whereas a reset could avoid flushing > > anything -- Peter found that the flushing was taking so long, the > > gadget might not be able to carry out a reset quickly enough if it used > > the disconnect callback. > > > > The version I have of this patch is incomplete; it requires a reset > > callback to be added to the composite driver. Peter, do you still want > > to make this change to g-mass-storage? > > > > Alan, this problem seems not to be existed at g_mass_storage, g_mass_storage > has not .disconnect API and only fsg_disable will be called when bus reset > occurs. That sounds like a bug. Shouldn't there be a disconnect callback? Don't we want to flush the dirty buffers when a disconnect occurs? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
