On Wed, Aug 27, 2014 at 05:26:37AM +0800, Felipe Balbi wrote: Hi Felipe, > Hi, > > On Tue, Aug 26, 2014 at 09:21:55PM +0000, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > > Sent: Tuesday, August 26, 2014 1:42 PM > > > > > > On Fri, Aug 22, 2014 at 04:56:46PM -0500, Felipe Balbi wrote: > > > > ... > > > > > yeah, it took longer than expected (been busy lately), but here's an > > > example trace with all trace points enabled: > > > > > > # tracer: nop > > > # > > > # entries-in-buffer/entries-written: 1038/1038 #P:1 > > > # > > > # _-----=> irqs-off > > > # / _----=> need-resched > > > # | / _---=> hardirq/softirq > > > # || / _--=> preempt-depth > > > # ||| / delay > > > # TASK-PID CPU# |||| TIMESTAMP FUNCTION > > > # | | | |||| | | > > > <idle>-0 [000] d.h. 155.653881: dwc3_readl: add fa39c40c value 00000004 > > > <idle>-0 [000] d.h. 155.653903: dwc3_readl: add fa39c408 value 00000100 > > > <idle>-0 [000] d.h. 155.653908: dwc3_writel: addr fa39c408 value 80000100 > > > > Looks like there is an inconsistency between readl/writel (add vs. > > addr). > > eagle eyes :-) > > > Other than that, I really like this. > > > > Reviewed-by: Paul Zimmerman <paulz@xxxxxxxxxxxx> > > thanks, pushed to my dwc3-tracepoints branch with your Reviewed-by, if > nobody makes any other comments until Friday, I'll promote it to > testing/next and later to next. If we can also add following two items: -- depcmd: trace depcmd params and cmd in dwc3_send_gadget_ep_cmd -- TRB: trace trb fields, trb address and ep number for which trb has been prepared in dwc3_prepare_one_trb These items were pretty helpful in debugging isoc issues. ~Pratyush > > cheers > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
