Re: gadgetfs regression: module refcount bug since 3.10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 31 Aug 2014, S. Lockwood-Childs wrote:

> gadgetfs has had a module refcount bug in all recent kernels, from v3.10 up
> through present. I realize that gadgetfs is deprecated in favor of functionfs
> nowadays, but probably you will want to fix it anyways since gadgetfs is still
> in the tree.

> More time spent with git-bisect showed that commit 3273097ee9c077
> "gadgetfs: don't bother with fops->owner" was the one that caused
> the regression. Simply reverting that commit restores old behavior with 
> balanced gets and puts: opening gadgetfs files increments the module 
> refcount, closing them decrements it.

You ought to CC: the person who wrote that commit.  He is in the best 
position to fix problems with it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux