On Fri, Aug 29, 2014 at 1:21 PM, Jassi Brar <jaswinder.singh@xxxxxxxxxx> wrote: >>> + >>> + rate = opts->p_srate; >>> + if (rate == 5512) { /* which implies 5512.5 practically */ >>> + rate = 55125; >>> + intvl *= 10; >>> + } >> Well, I'd say that Alan's approach as implemented in my v6 is still more >> comprehensible for anyone who'll try to understand this later, and it >> doesn't make any assumption on run time values. >> > I hope you realize this 5512 check has nothing to do with the Alan's > approach .... I can very well remove the check and it will still work! > It is only an added feature to provide accurate data rate because > ALSA API can not define fractional rates. > When ALSA says 5512Hz it is actually played at 5512.5Hz by a real codec. So I think *any* f_uac2 patch, for the rate fix, should do the above 5512->5512.5 conversion. -Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html