Hello Greg >> >> Not many drivers define the pci interface and there is no other driver >> that has the same vendor and product id. Therefore I see no hurt in >> adding both patches, one to make the driver broader, and another to >> fix pci-sysfs. >> >> Also, the change on pci-sysfs might affect more stuff and therefore >> take longer to be applied. > > As we have been printing the value to userspace in this way for well > over a decade now, and nothing has changed, I say it's a userspace bug > that you should fix instead. Don't work around broken user programs in > the kernel by changing something that has been stable for 10+ years. > > Ok, sorry, not 10+ years, the commit was written May of 2005, so 9 > years. > > Fix your module loading code please. On the other thread ( https://lkml.org/lkml/2014/8/27/242 ) we have agreed about fixing this thing on pci-sysfs.c . Still I think that there is no good reason to add the pci interface to the pci_table on this driver. Therefore I consider that this patch is still valid. What do you think. This patch is NACK? Thanks! > > thanks, > > greg k-h -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
