: Sergei Shtylyov [mailto:sergei.shtylyov@xxxxxxxxxxxxxxxxxx] > Sent: Wednesday, August 20, 2014 8:01 PM > To: Hayes Wang; netdev@xxxxxxxxxxxxxxx > Cc: nic_swsd; linux-kernel@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next 3/4] r8152: remove clear_bp function [...] > > r8152b_disable_aldps(tp); > > > > - rtl_clear_bp(tp); > > > > Why leave 2 empty lines? One is enough. The next patch would use another fucntion at the same location. I skip removing the empty line and re-adding it again. Is that better to do so? I would resend the patches if the answer is yes. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html