Re: [PATCH v2 3/3] usb: gadget/uvc: bump isoc requests from 4 to 16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

Thank you for the patch.

On Friday 08 August 2014 17:38:59 Michael Grzeschik wrote:
> While sending bigger images it is better to use more isochronous
> requests in flight. This patch bumps the default from 4 to 16.

What does this fix ? Does it increase throughput or decrease CPU load ? Have 
you made any measurement ? Would 8 requests also be too low ?

> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/uvc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/uvc.h b/drivers/usb/gadget/uvc.h
> index 7a9111d..49d9573 100644
> --- a/drivers/usb/gadget/uvc.h
> +++ b/drivers/usb/gadget/uvc.h
> @@ -99,7 +99,7 @@ extern unsigned int uvc_gadget_trace_param;
>  #define DRIVER_VERSION				"0.1.0"
>  #define DRIVER_VERSION_NUMBER			KERNEL_VERSION(0, 1, 0)
> 
> -#define UVC_NUM_REQUESTS			4
> +#define UVC_NUM_REQUESTS			16
>  #define UVC_MAX_REQUEST_SIZE			64
>  #define UVC_MAX_EVENTS				4

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux