Re: [PATCH v2 1/3] usb: gadget/uvc: fix possible lockup in uvc gadget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 19, 2014 at 06:33:07PM +0200, Laurent Pinchart wrote:
> On Tuesday 19 August 2014 09:11:57 Felipe Balbi wrote:
> > On Fri, Aug 08, 2014 at 05:38:57PM +0200, Michael Grzeschik wrote:
> > > If the pending buffers in the queue could not be pushed to the udc
> > > endpoint we have to cancel the uvc_queue. Otherwise the gadget will get
> > > stuck on this error. This patch calls uvc_queue_cancel if usb_ep_queue
> > > failed.
> > > 
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> > 
> > Laurent, is this good to be merged as a fix ?
> 
> The request completion code still makes me feel slightly uneasy due to fear of 
> race conditions, but as far as I can see this patch doesn't introduce a 
> regression in that area. Thus,
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> 
> Felipe, do you plan to push the patch as a fix for v3.17 ?

yeah, I do, unless you have other plans.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux