Re: [PATCH v2 2/3] usb: core: fix below build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 19 Aug 2014, Peter Chen wrote:

> linux-2.6/drivers/usb/core/hub.c: In function 'usb_disconnect':
> linux-2.6/drivers/usb/core/hub.c:2110: warning: 'hub' may be used uninitialized in this function
> linux-2.6/drivers/usb/core/hub.c:2111: warning: 'port1' may be used uninitialized in this function
> 
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
> Change for v2:
> - Delete the unnecessary change
> 
>  drivers/usb/core/hub.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 1fcad4d..170731c 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -2108,8 +2108,8 @@ void usb_disconnect(struct usb_device **pdev)
>  {
>  	struct usb_port *port_dev = NULL;
>  	struct usb_device *udev = *pdev;
> -	struct usb_hub *hub;
> -	int port1;
> +	struct usb_hub *hub = NULL;
> +	int port1 = 1;
>  
>  	/* mark the device as inactive, so any further urb submissions for
>  	 * this device (and any of its children) will fail immediately.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux