Hi Andrzej, Thank you for the patches. The series looks good, I only had a few comments. I have rebased the patches on top of my UVC gadget branch, addressed my comments (the modified patches are marked as such in the commit message) and pushed the result to git://linuxtv.org/pinchartl/media.git uvc/gadget Would you be able to test the result and hopefully ack it ? If everything is fine with you there's no need to submit a new version. On Wednesday 16 July 2014 16:54:10 Andrzej Pietrasiewicz wrote: > This patch series prepares the webcam gadget for supporting configfs. > Compared to the RFC: > > http://www.spinics.net/lists/linux-usb/msg103301.html > > - the patch fixing potential memory leak has been removed, > because it is already in Laurent's tree. > > - a patch changing function names to avoid conflicts has been added, > because now the said functions are not static. > > - Laurent's comments have been addressed. > > This series _does not_ contain a patch adding configfs support, > as Laurent suggests - first have the preparation series merged. > > This series depends on the gadget directory cleanup series: > > www.spinics.net/lists/linux-usb/msg110545.html > > Andrzej Pietrasiewicz (7): > usb: gadget: uvc: move module parameters from f_uvc > usb: gadget: uvc: rename functions to avoid conflicts with host uvc > usb: gadget: uvc: separately compile some components of f_uvc > usb: gadget: f_uvc: convert f_uvc to new function interface > usb: gadget: webcam: convert webcam to new interface of f_uvc > usb: gadget: f_uvc: remove compatibility layer > usb: gadget: f_uvc: use usb_gstrings_attach > > drivers/usb/gadget/Kconfig | 3 + > drivers/usb/gadget/function/Makefile | 2 + > drivers/usb/gadget/function/f_uvc.c | 254 +++++++++++++---------------- > drivers/usb/gadget/function/f_uvc.h | 13 +- > drivers/usb/gadget/function/u_uvc.h | 39 +++++ > drivers/usb/gadget/function/uvc.h | 1 + > drivers/usb/gadget/function/uvc_queue.c | 42 +++--- > drivers/usb/gadget/function/uvc_queue.h | 33 +++++ > drivers/usb/gadget/function/uvc_v4l2.c | 28 ++-- > drivers/usb/gadget/function/uvc_v4l2.h | 21 +++ > drivers/usb/gadget/function/uvc_video.c | 24 ++- > drivers/usb/gadget/function/uvc_video.h | 24 +++ > drivers/usb/gadget/legacy/Kconfig | 1 + > drivers/usb/gadget/legacy/webcam.c | 75 +++++++--- > 14 files changed, 344 insertions(+), 216 deletions(-) > create mode 100644 drivers/usb/gadget/function/u_uvc.h > create mode 100644 drivers/usb/gadget/function/uvc_v4l2.h > create mode 100644 drivers/usb/gadget/function/uvc_video.h -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
