Re: [PATCH 3/7] usb: gadget: uvc: separately compile some components of f_uvc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

Thank you for the patch.

On Wednesday 16 July 2014 16:54:13 Andrzej Pietrasiewicz wrote:
> Compile uvc_queue, uvc_v4l2, uvc_video separately so that later they can
> be all combined in a separately compiled f_uvc.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> ---
>  drivers/usb/gadget/function/f_uvc.c     |  2 ++
>  drivers/usb/gadget/function/f_uvc.h     |  8 +++++++
>  drivers/usb/gadget/function/uvc.h       |  1 +
>  drivers/usb/gadget/function/uvc_queue.c | 39  +++++++++++++----------------
>  drivers/usb/gadget/function/uvc_queue.h | 33 ++++++++++++++++++++++++++++
>  drivers/usb/gadget/function/uvc_v4l2.c  |  4 +++-
>  drivers/usb/gadget/function/uvc_v4l2.h  | 21 ++++++++++++++++++
>  drivers/usb/gadget/function/uvc_video.c | 10 ++++-----
>  drivers/usb/gadget/function/uvc_video.h | 24 ++++++++++++++++++++
>  drivers/usb/gadget/legacy/Makefile      |  2 +-
>  drivers/usb/gadget/legacy/webcam.c      |  6 +----
>  11 files changed, 115 insertions(+), 35 deletions(-)
>  create mode 100644 drivers/usb/gadget/function/uvc_v4l2.h
>  create mode 100644 drivers/usb/gadget/function/uvc_video.h

[snip]

> diff --git a/drivers/usb/gadget/function/uvc_v4l2.h
> b/drivers/usb/gadget/function/uvc_v4l2.h new file mode 100644
> index 0000000..ebcb1d1
> --- /dev/null
> +++ b/drivers/usb/gadget/function/uvc_v4l2.h
> @@ -0,0 +1,21 @@
> +/*
> + *	uvc_v4l2.h  --  USB Video Class Gadget driver
> + *
> + * Copyright (C) 2009-2010
> + *		Laurent Pinchart (laurent.pinchart@xxxxxxxxxxxxxxxx)
> + *
> + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> + *		http://www.samsung.com
> + *		Author: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#ifndef __UVC__V4L2__H__
> +#define __UVC__V4L2__H__
> +
> +extern struct v4l2_file_operations uvc_v4l2_fops;
> +
> +#endif /* __UVC__V4L2__H__ */

No need for double underscores inside the macro, it can just be 
__UVC_V4L2_H__. Same for uvc_video.h.

Apart from that,

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux