Re: [PATCH 2/7] usb: gadget: uvc: rename functions to avoid conflicts with host uvc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrzej,

Thank you for the patch.

On Wednesday 16 July 2014 16:54:12 Andrzej Pietrasiewicz wrote:
> Prepare for separate compilation of uvc function's components.
> Some symbols will have to be exported, so rename to avoid
> conflicts with functions of the same name in host uvc.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx>
> ---
>  drivers/usb/gadget/function/f_uvc.c     |  2 +-
>  drivers/usb/gadget/function/uvc_queue.c | 45 ++++++++++++++++--------------
>  drivers/usb/gadget/function/uvc_v4l2.c  | 24 +++++++++---------
>  drivers/usb/gadget/function/uvc_video.c | 18 ++++++-------
>  4 files changed, 45 insertions(+), 44 deletions(-)

[snip]

The patch looks good. For coherency reasons, could you please also rename 
uvc_video_pump and uvc_queue_head ?

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux