Re: [PATCH v2] usb: gadget/uvc: remove DRIVER_VERSION{,_NUMBER}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

Thank you for the patch.

On Thursday 14 August 2014 13:09:44 Michael Grzeschik wrote:
> As the driver is mainline we can remove the version numbers.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/usb/gadget/function/uvc.h      | 3 ---
>  drivers/usb/gadget/function/uvc_v4l2.c | 2 +-
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/gadget/function/uvc.h
> b/drivers/usb/gadget/function/uvc.h index 70bd426..11ba9ca 100644
> --- a/drivers/usb/gadget/function/uvc.h
> +++ b/drivers/usb/gadget/function/uvc.h
> @@ -97,9 +97,6 @@ extern unsigned int uvc_gadget_trace_param;
>   * Driver specific constants
>   */
> 
> -#define DRIVER_VERSION				"0.1.0"
> -#define DRIVER_VERSION_NUMBER			KERNEL_VERSION(0, 1, 0)
> -
>  #define UVC_NUM_REQUESTS			16
>  #define UVC_MAX_REQUEST_SIZE			64
>  #define UVC_MAX_EVENTS				4
> diff --git a/drivers/usb/gadget/function/uvc_v4l2.c
> b/drivers/usb/gadget/function/uvc_v4l2.c index 7eda39e..609ec87 100644
> --- a/drivers/usb/gadget/function/uvc_v4l2.c
> +++ b/drivers/usb/gadget/function/uvc_v4l2.c
> @@ -196,7 +196,7 @@ uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd,
> void *arg) strlcpy(cap->card, cdev->gadget->name, sizeof(cap->card));
>  		strlcpy(cap->bus_info, dev_name(&cdev->gadget->dev),
>  			sizeof cap->bus_info);
> -		cap->version = DRIVER_VERSION_NUMBER;
> +		cap->version = LINUX_VERSION_CODE;
>  		cap->capabilities = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
>  		break;
>  	}

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux