According to the datasheet, PHYPARAM1_PCS_TXDEEMPH_3P5DB is a correct name. Thus, a _3P5DB suffix for the PHYPARAM1_PCS_TXDEEMPH register bit field definition is added. In addition, PHYPARAM1_PCS_TXDEEMPH_3P5DB(_x) is added in order to keep the same style, as other register bit field definitions are used in this way. Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> --- These patches have a dependency on the patch ([PATCH] usb: phy: samsung: Remove unnecessary lines of register bit definitions). [1] [1] http://www.spinics.net/lists/linux-usb/msg111437.html drivers/usb/phy/phy-samsung-usb.h | 4 ++-- drivers/usb/phy/phy-samsung-usb3.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-samsung-usb.h b/drivers/usb/phy/phy-samsung-usb.h index 44e7605e4875..dc1dadea7ac9 100644 --- a/drivers/usb/phy/phy-samsung-usb.h +++ b/drivers/usb/phy/phy-samsung-usb.h @@ -185,8 +185,8 @@ #define PHYPARAM0_REF_LOSLEVEL (0x9 << 26) #define EXYNOS5_DRD_PHYPARAM1 (0x20) -#define PHYPARAM1_PCS_TXDEEMPH_MASK (0x3f << 0) -#define PHYPARAM1_PCS_TXDEEMPH (0x1c) +#define PHYPARAM1_PCS_TXDEEMPH_3P5DB_MASK (0x3f << 0) +#define PHYPARAM1_PCS_TXDEEMPH_3P5DB(_x) ((_x) << 0) #define EXYNOS5_DRD_PHYTERM (0x24) diff --git a/drivers/usb/phy/phy-samsung-usb3.c b/drivers/usb/phy/phy-samsung-usb3.c index cc0819248acf..97151b9065e4 100644 --- a/drivers/usb/phy/phy-samsung-usb3.c +++ b/drivers/usb/phy/phy-samsung-usb3.c @@ -98,8 +98,8 @@ static void samsung_exynos5_usb3phy_enable(struct samsung_usbphy *sphy) phyparam1 = readl(regs + EXYNOS5_DRD_PHYPARAM1); /* Set Tx De-Emphasis level */ - phyparam1 &= ~PHYPARAM1_PCS_TXDEEMPH_MASK; - phyparam1 |= PHYPARAM1_PCS_TXDEEMPH; + phyparam1 &= ~PHYPARAM1_PCS_TXDEEMPH_3P5DB_MASK; + phyparam1 |= PHYPARAM1_PCS_TXDEEMPH_3P5DB(0x1c); writel(phyparam1, regs + EXYNOS5_DRD_PHYPARAM1); phybatchg = readl(regs + EXYNOS5_DRD_PHYBATCHG); -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
