Hi, On 07/10/2014 01:17 PM, Hans de Goede wrote: > Hi Sarah, Matthias, et al, > > I've been running a full Linux distro from an uas enclosure with a ssd > for testing purposes (mostly for testing the distro on different > hardware but also for uas testing). > > While testing this on a Thinkpad T440s I noticed the error > from $subject happening exactly once in the log. This always happens > when initializing the uas disk enclosure with the ssd. This happens > with both 3.15 and 3.16-rc4. > > I've run a battery of tests to try and pin this down, here is the > test matrix: > > T440s (Ivy Bridge) E6430 (Sandy Bridge) Desktop (NEC) > Renesas uPD720231 + ssd: FAIL (*) OK OK (**) > ASM1053E + hdd : OK OK OK (**) > ASM1053E + ssd : OK OK OK (**) > > *) Putting an USB-3 hub in between makes no difference > **) Tested with an USB-3 hub in between > > Where FAIL means that the error shows up. > > The 2 enclosures tested with are: > Renesas uPD720231: http://www.amazon.com/SEDNA-SE-EH-322-U-External-Enclosure-Support/dp/B00E0MLIVE > ASM1053E: http://plugable.com/products/usb3-sata-uasp1 > > The 3 xhci controllers tested with are: > > T440s (Ivy Bridge): > 00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC [8086:9c31] (rev 04) > > E6430 (Sandy Bridge): > 00:14.0 USB controller [0c03]: Intel Corporation 7 Series/C210 Series Chipset Family USB xHCI Host Controller [8086:1e31] (rev 04) Correction the T440s is Haswell, the E6430 Ivy Bridge, Sandy Bridge never had USB 3 (in its companion chipset). Sorry, note the lspci is correct. > Desktop (NEC): > 01:00.0 USB controller [0c03]: NEC Corporation uPD720200 USB 3.0 Host Controller [1033:0194] (rev 04) > > So this seems to only happen (and even then only once on init) when > pairing a Renesas uPD720231 with an Ivy Bridge chipset xHCI controller. > > For completeness sake, the ssd used in both cases was: a 120G Crucial M500, > model string: Crucial_ CT120M500SSD1 . In the mean time I've found what I believe is a proper fix for this, we've special handling for COMP_STOP_INVAL, but not for COMP_STOP, judging from the comment above the special handling this handling should be equally applied to COMP_STOP and that fixes this error being logged. I'll send a patch to fix this separately. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
