On Tue, Jul 15, 2014 at 07:50:35PM +0200, Robert Jarzmik wrote:
> Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> writes:
>
> > Hello.
> >
> >> @@ -2524,35 +2518,21 @@ static int pxa_udc_probe(struct platform_device *pdev)
> >> pxa_eps_setup(udc);
> >>
> >> /* irq setup after old hardware state is cleaned up */
> >> - retval = request_irq(udc->irq, pxa_udc_irq,
> >> - IRQF_SHARED, driver_name, udc);
> >> + retval = devm_request_irq(&pdev->dev, udc->irq, pxa_udc_irq,
> >> + IRQF_SHARED, driver_name, udc);
> >> if (retval != 0) {
> >> dev_err(udc->dev, "%s: can't get irq %i, err %d\n",
> >> driver_name, udc->irq, retval);
> >> - goto err_irq;
> >> + return retval;
> >
> > You forgot clk_unprepare().
>
> Right. As I had said before, I wanted this serie to be the last. And this error
> was already present in the previous version.
>
> Therefore, let's drop this patch from the serie, I'll submit it apart. Felipe
> let's consider patch 1, 2 and 4 please.
will do. Just give me a couple days as I'm dealing with a lot right now
;-)
cheers
--
balbi
Attachment:
signature.asc
Description: Digital signature
