Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> writes:
> Hello.
>
>> @@ -2524,35 +2518,21 @@ static int pxa_udc_probe(struct platform_device *pdev)
>> pxa_eps_setup(udc);
>>
>> /* irq setup after old hardware state is cleaned up */
>> - retval = request_irq(udc->irq, pxa_udc_irq,
>> - IRQF_SHARED, driver_name, udc);
>> + retval = devm_request_irq(&pdev->dev, udc->irq, pxa_udc_irq,
>> + IRQF_SHARED, driver_name, udc);
>> if (retval != 0) {
>> dev_err(udc->dev, "%s: can't get irq %i, err %d\n",
>> driver_name, udc->irq, retval);
>> - goto err_irq;
>> + return retval;
>
> You forgot clk_unprepare().
Right. As I had said before, I wanted this serie to be the last. And this error
was already present in the previous version.
Therefore, let's drop this patch from the serie, I'll submit it apart. Felipe
let's consider patch 1, 2 and 4 please.
Cheers.
--
Robert
PS: The full rationale of the patch delaying :
There is another legacy problem with the clock which appeared with migration
towards clock infrastructure : preparing the clock is not enough, it should be
enabled as well right from the start, because the clock is fed to the UDC IP,
and without it the registers set up initially are lost.
Of course this problem was discovered because of "clock ignore unused" clocks
framework feature. It doesn't touch this driver yet as PXA is not ported to
clocks framework, yet it must be fixed, hence the delaying of this patch too.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
