Re: [PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs

Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx> · Thu, 10 Jul 2014 18:12:48 +0300

Thierry,

Since Stephen's on a vacation, I'd like to double-check with you that 
the DT changes looks good. Greg has applied these to the USB tree today.

Thanks,
Tuomas

On 04/07/14 04:09, Tuomas Tynkkynen wrote:
Add new properties to all of the Tegra PHYs that are now required
according to the binding.

In order to stay compatible with old device trees, the USB drivers
will still function without these reset properties but with the old,
potentially buggy behaviour.

Signed-off-by: Tuomas Tynkkynen <ttynkkynen@xxxxxxxxxx>
---
v2 changes: new patch, didn't exist in v1
  arch/arm/boot/dts/tegra114.dtsi |    5 +++++
  arch/arm/boot/dts/tegra124.dtsi |    7 +++++++
  arch/arm/boot/dts/tegra20.dtsi  |    7 +++++++
  arch/arm/boot/dts/tegra30.dtsi  |    7 +++++++
  4 files changed, 26 insertions(+)

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 335a1d8..80b8edd 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -672,6 +672,8 @@
  			 <&tegra_car TEGRA114_CLK_PLL_U>,
  			 <&tegra_car TEGRA114_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 22>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <0>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
@@ -682,6 +684,7 @@
  		nvidia,hssquelch-level = <2>;
  		nvidia,hsdiscon-level = <5>;
  		nvidia,xcvr-hsslew = <12>;
+		nvidia,has-utmi-pad-registers;
  		status = "disabled";
  	};

@@ -705,6 +708,8 @@
  			 <&tegra_car TEGRA114_CLK_PLL_U>,
  			 <&tegra_car TEGRA114_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 59>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <0>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index d675186..5b14d79 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -643,6 +643,8 @@
  			 <&tegra_car TEGRA124_CLK_PLL_U>,
  			 <&tegra_car TEGRA124_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 22>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <0>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
@@ -653,6 +655,7 @@
  		nvidia,hssquelch-level = <2>;
  		nvidia,hsdiscon-level = <5>;
  		nvidia,xcvr-hsslew = <12>;
+		nvidia,has-utmi-pad-registers;
  		status = "disabled";
  	};

@@ -677,6 +680,8 @@
  			 <&tegra_car TEGRA124_CLK_PLL_U>,
  			 <&tegra_car TEGRA124_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 58>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <0>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
@@ -711,6 +716,8 @@
  			 <&tegra_car TEGRA124_CLK_PLL_U>,
  			 <&tegra_car TEGRA124_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 59>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <0>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index 243d84c..1908f69 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -645,6 +645,8 @@
  			 <&tegra_car TEGRA20_CLK_CLK_M>,
  			 <&tegra_car TEGRA20_CLK_USBD>;
  		clock-names = "reg", "pll_u", "timer", "utmi-pads";
+		resets = <&tegra_car 22>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,has-legacy-mode;
  		nvidia,hssync-start-delay = <9>;
  		nvidia,idle-wait-delay = <17>;
@@ -653,6 +655,7 @@
  		nvidia,xcvr-setup = <9>;
  		nvidia,xcvr-lsfslew = <1>;
  		nvidia,xcvr-lsrslew = <1>;
+		nvidia,has-utmi-pad-registers;
  		status = "disabled";
  	};

@@ -676,6 +679,8 @@
  			 <&tegra_car TEGRA20_CLK_PLL_U>,
  			 <&tegra_car TEGRA20_CLK_CDEV2>;
  		clock-names = "reg", "pll_u", "ulpi-link";
+		resets = <&tegra_car 58>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		status = "disabled";
  	};

@@ -700,6 +705,8 @@
  			 <&tegra_car TEGRA20_CLK_CLK_M>,
  			 <&tegra_car TEGRA20_CLK_USBD>;
  		clock-names = "reg", "pll_u", "timer", "utmi-pads";
+		resets = <&tegra_car 59>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <9>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index 0b1ede9..6b35c29 100644
--- a/arch/arm/boot/dts/tegra30.dtsi
+++ b/arch/arm/boot/dts/tegra30.dtsi
@@ -790,6 +790,8 @@
  			 <&tegra_car TEGRA30_CLK_PLL_U>,
  			 <&tegra_car TEGRA30_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 22>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <9>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
@@ -801,6 +803,7 @@
  		nvidia,xcvr-hsslew = <32>;
  		nvidia,hssquelch-level = <2>;
  		nvidia,hsdiscon-level = <5>;
+		nvidia,has-utmi-pad-registers;
  		status = "disabled";
  	};

@@ -824,6 +827,8 @@
  			 <&tegra_car TEGRA30_CLK_PLL_U>,
  			 <&tegra_car TEGRA30_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 58>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <9>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;
@@ -858,6 +863,8 @@
  			 <&tegra_car TEGRA30_CLK_PLL_U>,
  			 <&tegra_car TEGRA30_CLK_USBD>;
  		clock-names = "reg", "pll_u", "utmi-pads";
+		resets = <&tegra_car 59>, <&tegra_car 22>;
+		reset-names = "usb", "utmi-pads";
  		nvidia,hssync-start-delay = <0>;
  		nvidia,idle-wait-delay = <17>;
  		nvidia,elastic-limit = <16>;


--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html







