host/ohci-tmio.c:104: possible novice coding error ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello there,

[linux-3.16-rc4/drivers/usb/host/ohci-tmio.c:104]: (warning) Redundant bitwise operation on 'pm' in 'switch' statement. 'break;' missing?

    switch (ohci->num_ports) {
        default:
            dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports);
        case 3:
            pm |= CCR_PM_USBPW3;
        case 2:
            pm |= CCR_PM_USBPW2;
        case 1:
            pm |= CCR_PM_USBPW1;
    }

Suggest add missing breaks.

Regards

David Binderman


 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux