On Mon, 30 Jun 2014 07:45:43 -0700 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > From: Of Richard Leitner > > > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > > > > > Due to the fact the strings are spread over different source files the > > > > > > PREFIX definition is moved to u_serial.h > > > > > > > > > > Lots of changes like: > > > > > > - DBG(cdev, "acm ttyGS%d completion, err %d\n", > > > > > > - acm->port_num, req->status); > > > > > > + DBG(cdev, "acm %s%d completion, err %d\n", > > > > > > + PREFIX, acm->port_num, req->status); > > > > > > > Use the "proper" debug macros that the kernel provides you (i.e. > dev_dbg() and family) and then you don't need to put the string in there > at all, the kernel will do it automatically for you, in the correct > format, so that all userspace tools can properly track what is going on. > > So please remove the horrid DBG() macro entirely. > It may be a clumsy question, but where do I get the device struct for the ttyGS from? (acm->port.ioport->port_tty ?!?) The one for the USB gadget is cdev->gadget->dev if I've seen it correctly? Thank you for your help! regards, richard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
