Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: > > Replace all hardcoded ttyGS strings with the PREFIX macro. > > Why? Because IMHO if PREFIX is available it should be used everywhere possible. Furthermore if you change the PREFIX the debug output wouldn't be consistent any more. > > > Therefore the PREFIX definition is moved to u_serial.h. > > Why? Otherwise f_acm.c, f_obex.c and f_serial.c wouldn't know it. Isn't u_serial.h the right place for it? > > > Furthermore the modified files are checkpatch.pl compliant now. > > You are doing two different things here in the same patch. Please split > it up into two different patches. Ok, I'll do that. > > thanks, > > greg k-h thanks & regards, richard -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
