Re:Re: Re: move ZTE CDMA device pid from zte_ev.c back to option.c and modify a parameter in zte_ev.ko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



i'm sorry, i think you said is the patch of my submit yesterday.i misunderstand you means.


At 2014-06-23 06:52:22, "Johan Hovold" <johan@xxxxxxxxxx> wrote:
>On Mon, Jun 23, 2014 at 06:15:52PM +0800, 刘磊 wrote:
>> 
>> >Could you try the first patch (only) and see if it fixes the problem?
>> >Does it also fix the problem you're having with PID 0xfffe?
>> 
>> yes, the first patch could solve the problem with pid 0xfffe.
>
>Did you test my first patch ("USB: zte_ev: add proper line-control
>handling")? And it makes zte_ev work with 0xfffe?
>
>> >When you you have tested the first patch, could you test the second
>> >one as well and see if everything still works?
>> 
>> yes, the second path i had been tested and it works fine.
>
>So with both my patching (i.e. including "USB: zte_ev: reimplement
>line-coding handling") evertything works, including the device with PID
>0xfffe?

today, i tested you patch in ubuntu and opensuse. 
both can work.  it work fine in ubuntu but is not very stable in Opensuse.

> 
>> In you other two mails, you want to modify the line-coding handling,
>> but i'm not sure that have some problem.  otherwise, it will be have
>> some problem in the pid  of 0xfffe for our company(the pid of 0xfffe
>> belongs our company).  
>
>I'm not sure I understand what you're trying to say here?
>
>> i suggest you sould move the pid of 0xfffe from zte_ev.c to option.c
>> at first and then modify others.
>
>Why? If you tested the patches and it works also for 0xfffe then it
>could remain in zte_ev.c, right?


yes, if the patch works fine it can remain in zte_ev.c.
we hope to move 0xfffe to option.c, we has been tested normal when move 0xfffe to option.c in some our support system.
For product evaluations, and In order to ensure there is no problem, Because all 0xfffe devices are provided by zte of our company.
 


>
>> i don't know why create the file of zte_ev.c that is not necessary. i
>> suggest we can move all the pid from zte_ev.c to option.c.
>
>Again, why do you think that that is needed?

i think all pid of zte device in zte_ev.c has according with option.c.
we have tried to asked, the file of zte_ev.c was not added by our company of zte.
May be submitted by some of our customers, but I'm not sure.



>
>Thanks,
>Johan
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux