On Wednesday, June 11, 2014 12:12 AM, Sergei Shtylyov wrote: > On 06/10/2014 10:54 AM, Robert Jarzmik wrote: > >> On 06/09/2014 11:52 PM, Robert Jarzmik wrote: > >>> regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >>> + udc->regs = devm_request_and_ioremap(&pdev->dev, regs); > > >> Isn't this function deprecated in favor of devm_ioremap_resource()? > > > I don't know.It's not marked as deprecated. Right, I sent the patch to mark devm_request_and_ioremap() as __deprecated. However, Greg KH wanted to just remove it from the kernel. > > OK, formally it isn't. However, the uses of devm_request_and_ioremap() are > gradually replaced by devm_ioremap_resource(). Currently, two drivers are using the legacy devm_request_and_ioremap() as below. ./drivers/bus/brcmstb_gisb.c ./drivers/gpu/drm/armada/armada_crtc.c I already sent the patches to replace it; however, the maintainers are ignoring these patches. I think that it's the time to remove it. So, I will sent single patch to Greg KH in order to remove all usages of devm_request_and_ioremap() from the kernel. Best regards, Jingoo Han > > > Could you give me a pointer ? > > Only to the patches replacing the former by the latter, I'm afraid... > However, note that the former is implemented as a wrapper of the latter, so > it makes little sense to use it instead of a direct call to > devm_ioremap_resource(). > > [...] > > > Cheers. > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
