On Thu, 5 Jun 2014, Marcus Nutzinger wrote: > Hi Sergei, > > On Jun 5, 2014, at 4:18 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > > > Please also specify that commit's summary line in parens. > > I'll resubmit the updated patch in a minute! > > >> + /* other endpoints were all decoupled from this device */ > >> + spin_lock_irq(&dev->lock); > >> + dev->state = STATE_DEV_DISABLED; > >> + spin_unlock_irq(&dev->lock); > > > > Not sure I understand why you need spinlock here... isn't the assignment atomic already? > > > Sure, an assignment might be atomic. However, following the policy of commit 7489d149 > (USB: gadgetfs cleanups) all ep0 state changes shall be protected by spinlocks. Sometimes an assignment needs to be protected by a lock, even though the assignment itself is atomic. This happens, for example, when some other code executes a lock-protected region that expects the variable not to change. I don't know if that's the case here. But this example shows that in general, one sometimes needs locks in places where you wouldn't expect them. In fact, it may even be necessary to take and release a lock, without doing anything in between! Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
