Hi Sergei, On Jun 5, 2014, at 4:18 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Please also specify that commit's summary line in parens. I'll resubmit the updated patch in a minute! >> + /* other endpoints were all decoupled from this device */ >> + spin_lock_irq(&dev->lock); >> + dev->state = STATE_DEV_DISABLED; >> + spin_unlock_irq(&dev->lock); > > Not sure I understand why you need spinlock here... isn't the assignment atomic already? Sure, an assignment might be atomic. However, following the policy of commit 7489d149 (USB: gadgetfs cleanups) all ep0 state changes shall be protected by spinlocks. Thanks, Marcus -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
