RE: [PATCH v2 net-next 3/8] net: cdc_ncm: inform usbnet when rx buffers are reduced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Bjørn Mork
...
> > Since you are now copying the data out of the URB's skb before
> > passing the ethernet packet upstream, is there ever any real
> > requirement to use a small rx_max? or ever change rx_max?
> 
> Yes.  usbnet doesn't currently recycle skbs.  Continuously allocating 32
> kB skbs (or even 64 kB truesize, which is the current cdc_ncm worst
> case) on memory constrained hosts is bound to fail eventually.

Getting usbnet to recycle skb shouldn't be too hard - and will
be an immediate gain for most of the drivers.
I think they would all benefit from copying frames to new skb.

	David

��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux