[PATCH 1/3] usb: fix hub_handle_remote_wakeup() only exists for CONFIG_PM=y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

Stephen notes:
  After merging the usb tree, today's linux-next build (sparc64 defconfig)
  failed like this:

  drivers/usb/core/hub.c: In function 'port_event':
  drivers/usb/core/hub.c:4853:2: error: implicit declaration of function
  'hub_handle_remote_wakeup' [-Werror=implicit-function-declaration]

  Caused by commits af376a461cf0 ("usb: refactor port handling in
  hub_events()") and 7e73be227b15 ("usb: hub_handle_remote_wakeup()
  depends on CONFIG_PM_RUNTIME=y") This build has CONFIG_PM not set ...

The kbuild robot also reported this.

Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
---
 drivers/usb/core/hub.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 6346fb2acbd7..db6287025c06 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3966,6 +3966,12 @@ EXPORT_SYMBOL_GPL(usb_disable_ltm);
 void usb_enable_ltm(struct usb_device *udev) { }
 EXPORT_SYMBOL_GPL(usb_enable_ltm);
 
+static int hub_handle_remote_wakeup(struct usb_hub *hub, unsigned int port,
+		u16 portstatus, u16 portchange)
+{
+	return 0;
+}
+
 #endif	/* CONFIG_PM */
 
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux