2014-05-29 8:03 GMT-07:00 Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>: > On Thu, 29 May 2014, Alex Smith wrote: > >> From: David Daney <david.daney@xxxxxxxxxx> >> >> The device tree will *always* have correct ehci/ohci clock >> configuration, so use it. This allows us to remove a big chunk of >> platform configuration code from octeon-platform.c. > > Instead of doing this, how about moving the octeon2_usb_clocks_start() > and _stop() routines into octeon-platform.c, and then using the > ehci-platform and ohci-platform drivers instead of special-purpose > ehci-octeon and ohci-octeon drivers? How about they get their changes in now, and eventually they cleanup the octeon driver in the future? My personal experience with that sort of request, is that I had to come up with 50+ patches to clean up the Kconfig mess that USB drivers had back then and I still have not re-submitted the bcm63xx USB patchset. It is fair to pinpoint what *should* be improved and what the next steps could look like, it is not fair to ask people submitting changes to come up with a much bigger task before their patches can be merged. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
