On Thu, May 15, 2014 at 12:07:19AM +0800, Greg KH wrote: > On Mon, May 12, 2014 at 11:45:23AM +0530, Pratyush Anand wrote: > > +static DEVICE_ATTR(u3_entry, S_IWUSR, NULL, issue_u3_entry); > > For this, and the other DEVICE_ATTR() entries, please use > DEVICE_ATTR_RO() or _RW(), or _WO(), depending on what you are wanting > the permissions to be. I'm trying to get rid of all "raw" DEVICE_ATTR() > entries in the kernel where possible. OK. Regards Pratyush > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html