Dear All - in general,
@Felipe - in particular,
[This is a resent version generated with git format-patch -M90%]
I would like to ask your opinion on rearranging the way the source code files
are located in the drivers/usb/gadget directory.
These are the reasons for doing such a change:
- there are ~130 source code files already in a clean tree
- when all gadgets and some udc drivers are built as modules then,
including the by-products of the build (*.o, *.ko, *.mod.c, .*.cmd),
the number easily grows to ~500 files
- files serving different purpose (udc chip drivers, actual gadget functions'
implementations, legacy gadgets) are located side-by-side which might cause
confusion
- gadget's Kconfig and Makefile tend to be lengthy.
What I suggest is to create separate subdirectories:
- "udc" for UDC chip drivers
- "function" for actual usb functions' implementations
- "legacy" for gadgets compiled as statically composed modules
while at the gadget's root level there are files related to the composite
framework.
After the patches are applied the gadget subdirectory looks much cleaner.
What I would like to ask is:
1) Do you find the idea useful?
2) The patches size is considerably large (the changes are mainly
of "rename" type with similarity index 97..100%, though).
Is it better to have a small number of large patches or trade off
the patches size against the number of patches and have a large number
of small patches?
3) Checkpatch issues about 2000 warnings on the 3 patches in this series.
I believe the vast majority of them are warnings on issues already present
in the source code, it is just when the files are moved around then all
issues in a file are reported at the same time. So what I am asking
is whether to:
- leave the warnings as they are?
- remove the warnings first and then refactor?
- if removing, leave the CamelCase warnings as they are?
Clearing 2000 warnings is a considerable amount of work which I am willing
to do provided the general idea of this series is accepted.
4) I don't have all kinds of hardware available, so for some drivers I can only
do compile-testing. Is it ok?
*** BLURB HERE ***
Andrzej Pietrasiewicz (3):
usb: gadget: Gadget directory cleanup - group legacy gadgets
usb: gadget: Gadget directory cleanup - group UDC drivers
usb: gadget: Gadget directory cleanup - group usb functions
drivers/usb/gadget/Kconfig | 830 +--------------------
drivers/usb/gadget/Makefile | 98 +--
drivers/usb/gadget/epautoconf.c | 2 +-
drivers/usb/gadget/function/Makefile | 31 +
drivers/usb/gadget/{ => function}/f_acm.c | 2 +-
drivers/usb/gadget/{ => function}/f_ecm.c | 0
drivers/usb/gadget/{ => function}/f_eem.c | 0
drivers/usb/gadget/{ => function}/f_fs.c | 2 +-
drivers/usb/gadget/{ => function}/f_hid.c | 2 +-
drivers/usb/gadget/{ => function}/f_loopback.c | 2 +-
drivers/usb/gadget/{ => function}/f_mass_storage.c | 4 +-
drivers/usb/gadget/{ => function}/f_mass_storage.h | 0
drivers/usb/gadget/{ => function}/f_midi.c | 2 +-
drivers/usb/gadget/{ => function}/f_ncm.c | 0
drivers/usb/gadget/{ => function}/f_obex.c | 2 +-
drivers/usb/gadget/{ => function}/f_phonet.c | 0
drivers/usb/gadget/{ => function}/f_rndis.c | 0
drivers/usb/gadget/{ => function}/f_serial.c | 2 +-
drivers/usb/gadget/{ => function}/f_sourcesink.c | 4 +-
drivers/usb/gadget/{ => function}/f_subset.c | 0
drivers/usb/gadget/{ => function}/f_uac1.c | 0
drivers/usb/gadget/{ => function}/f_uac2.c | 0
drivers/usb/gadget/{ => function}/f_uvc.c | 0
drivers/usb/gadget/{ => function}/f_uvc.h | 0
drivers/usb/gadget/{ => function}/g_zero.h | 0
drivers/usb/gadget/{ => function}/ndis.h | 0
drivers/usb/gadget/{ => function}/rndis.c | 0
drivers/usb/gadget/{ => function}/rndis.h | 0
drivers/usb/gadget/{ => function}/storage_common.c | 0
drivers/usb/gadget/{ => function}/storage_common.h | 0
drivers/usb/gadget/{ => function}/u_ecm.h | 0
drivers/usb/gadget/{ => function}/u_eem.h | 0
drivers/usb/gadget/{ => function}/u_ether.c | 0
drivers/usb/gadget/{ => function}/u_ether.h | 2 +-
.../usb/gadget/{ => function}/u_ether_configfs.h | 0
drivers/usb/gadget/{ => function}/u_fs.h | 0
drivers/usb/gadget/{ => function}/u_gether.h | 0
drivers/usb/gadget/{ => function}/u_ncm.h | 0
drivers/usb/gadget/{ => function}/u_phonet.h | 0
drivers/usb/gadget/{ => function}/u_rndis.h | 0
drivers/usb/gadget/{ => function}/u_serial.c | 0
drivers/usb/gadget/{ => function}/u_serial.h | 0
drivers/usb/gadget/{ => function}/u_uac1.c | 0
drivers/usb/gadget/{ => function}/u_uac1.h | 2 +-
drivers/usb/gadget/{ => function}/uvc.h | 0
drivers/usb/gadget/{ => function}/uvc_queue.c | 0
drivers/usb/gadget/{ => function}/uvc_queue.h | 0
drivers/usb/gadget/{ => function}/uvc_v4l2.c | 0
drivers/usb/gadget/{ => function}/uvc_video.c | 0
drivers/usb/gadget/legacy/Kconfig | 475 ++++++++++++
drivers/usb/gadget/legacy/Makefile | 39 +
drivers/usb/gadget/{ => legacy}/acm_ms.c | 4 +-
drivers/usb/gadget/{ => legacy}/audio.c | 10 +-
drivers/usb/gadget/{ => legacy}/cdc2.c | 6 +-
drivers/usb/gadget/{ => legacy}/dbgp.c | 2 +-
drivers/usb/gadget/{ => legacy}/ether.c | 12 +-
drivers/usb/gadget/{ => legacy}/g_ffs.c | 12 +-
drivers/usb/gadget/{ => legacy}/gmidi.c | 4 +-
drivers/usb/gadget/{ => legacy}/hid.c | 4 +-
drivers/usb/gadget/{ => legacy}/inode.c | 0
drivers/usb/gadget/{ => legacy}/mass_storage.c | 2 +-
drivers/usb/gadget/{ => legacy}/multi.c | 12 +-
drivers/usb/gadget/{ => legacy}/ncm.c | 4 +-
drivers/usb/gadget/{ => legacy}/nokia.c | 10 +-
drivers/usb/gadget/{ => legacy}/printer.c | 2 +-
drivers/usb/gadget/{ => legacy}/serial.c | 4 +-
drivers/usb/gadget/{ => legacy}/tcm_usb_gadget.c | 0
drivers/usb/gadget/{ => legacy}/tcm_usb_gadget.h | 0
drivers/usb/gadget/{ => legacy}/webcam.c | 10 +-
drivers/usb/gadget/{ => legacy}/zero.c | 2 +-
drivers/usb/gadget/udc/Kconfig | 383 ++++++++++
drivers/usb/gadget/udc/Makefile | 32 +
drivers/usb/gadget/{ => udc}/amd5536udc.c | 0
drivers/usb/gadget/{ => udc}/amd5536udc.h | 0
drivers/usb/gadget/{ => udc}/at91_udc.c | 0
drivers/usb/gadget/{ => udc}/at91_udc.h | 0
drivers/usb/gadget/{ => udc}/atmel_usba_udc.c | 0
drivers/usb/gadget/{ => udc}/atmel_usba_udc.h | 0
drivers/usb/gadget/{ => udc}/bcm63xx_udc.c | 0
drivers/usb/gadget/{ => udc}/dummy_hcd.c | 0
drivers/usb/gadget/{ => udc}/fotg210-udc.c | 0
drivers/usb/gadget/{ => udc}/fotg210.h | 0
drivers/usb/gadget/{ => udc}/fsl_mxc_udc.c | 0
drivers/usb/gadget/{ => udc}/fsl_qe_udc.c | 0
drivers/usb/gadget/{ => udc}/fsl_qe_udc.h | 0
drivers/usb/gadget/{ => udc}/fsl_udc_core.c | 0
drivers/usb/gadget/{ => udc}/fsl_usb2_udc.h | 0
drivers/usb/gadget/{ => udc}/fusb300_udc.c | 0
drivers/usb/gadget/{ => udc}/fusb300_udc.h | 0
drivers/usb/gadget/{ => udc}/gadget_chips.h | 0
drivers/usb/gadget/{ => udc}/goku_udc.c | 0
drivers/usb/gadget/{ => udc}/goku_udc.h | 0
drivers/usb/gadget/{ => udc}/gr_udc.c | 0
drivers/usb/gadget/{ => udc}/gr_udc.h | 0
drivers/usb/gadget/{ => udc}/lpc32xx_udc.c | 0
drivers/usb/gadget/{ => udc}/m66592-udc.c | 0
drivers/usb/gadget/{ => udc}/m66592-udc.h | 0
drivers/usb/gadget/{ => udc}/mv_u3d.h | 0
drivers/usb/gadget/{ => udc}/mv_u3d_core.c | 0
drivers/usb/gadget/{ => udc}/mv_udc.h | 0
drivers/usb/gadget/{ => udc}/mv_udc_core.c | 0
drivers/usb/gadget/{ => udc}/net2272.c | 0
drivers/usb/gadget/{ => udc}/net2272.h | 0
drivers/usb/gadget/{ => udc}/net2280.c | 0
drivers/usb/gadget/{ => udc}/net2280.h | 0
drivers/usb/gadget/{ => udc}/omap_udc.c | 0
drivers/usb/gadget/{ => udc}/omap_udc.h | 0
drivers/usb/gadget/{ => udc}/pch_udc.c | 0
drivers/usb/gadget/{ => udc}/pxa25x_udc.c | 0
drivers/usb/gadget/{ => udc}/pxa25x_udc.h | 0
drivers/usb/gadget/{ => udc}/pxa27x_udc.c | 0
drivers/usb/gadget/{ => udc}/pxa27x_udc.h | 0
drivers/usb/gadget/{ => udc}/r8a66597-udc.c | 0
drivers/usb/gadget/{ => udc}/r8a66597-udc.h | 0
drivers/usb/gadget/{ => udc}/s3c-hsotg.c | 0
drivers/usb/gadget/{ => udc}/s3c-hsotg.h | 0
drivers/usb/gadget/{ => udc}/s3c-hsudc.c | 0
drivers/usb/gadget/{ => udc}/s3c2410_udc.c | 0
drivers/usb/gadget/{ => udc}/s3c2410_udc.h | 0
drivers/usb/gadget/{ => udc}/udc-core.c | 0
120 files changed, 1027 insertions(+), 989 deletions(-)
create mode 100644 drivers/usb/gadget/function/Makefile
rename drivers/usb/gadget/{ => function}/f_acm.c (99%)
rename drivers/usb/gadget/{ => function}/f_ecm.c (100%)
rename drivers/usb/gadget/{ => function}/f_eem.c (100%)
rename drivers/usb/gadget/{ => function}/f_fs.c (99%)
rename drivers/usb/gadget/{ => function}/f_hid.c (99%)
rename drivers/usb/gadget/{ => function}/f_loopback.c (99%)
rename drivers/usb/gadget/{ => function}/f_mass_storage.c (99%)
rename drivers/usb/gadget/{ => function}/f_mass_storage.h (100%)
rename drivers/usb/gadget/{ => function}/f_midi.c (99%)
rename drivers/usb/gadget/{ => function}/f_ncm.c (100%)
rename drivers/usb/gadget/{ => function}/f_obex.c (99%)
rename drivers/usb/gadget/{ => function}/f_phonet.c (100%)
rename drivers/usb/gadget/{ => function}/f_rndis.c (100%)
rename drivers/usb/gadget/{ => function}/f_serial.c (99%)
rename drivers/usb/gadget/{ => function}/f_sourcesink.c (99%)
rename drivers/usb/gadget/{ => function}/f_subset.c (100%)
rename drivers/usb/gadget/{ => function}/f_uac1.c (100%)
rename drivers/usb/gadget/{ => function}/f_uac2.c (100%)
rename drivers/usb/gadget/{ => function}/f_uvc.c (100%)
rename drivers/usb/gadget/{ => function}/f_uvc.h (100%)
rename drivers/usb/gadget/{ => function}/g_zero.h (100%)
rename drivers/usb/gadget/{ => function}/ndis.h (100%)
rename drivers/usb/gadget/{ => function}/rndis.c (100%)
rename drivers/usb/gadget/{ => function}/rndis.h (100%)
rename drivers/usb/gadget/{ => function}/storage_common.c (100%)
rename drivers/usb/gadget/{ => function}/storage_common.h (100%)
rename drivers/usb/gadget/{ => function}/u_ecm.h (100%)
rename drivers/usb/gadget/{ => function}/u_eem.h (100%)
rename drivers/usb/gadget/{ => function}/u_ether.c (100%)
rename drivers/usb/gadget/{ => function}/u_ether.h (99%)
rename drivers/usb/gadget/{ => function}/u_ether_configfs.h (100%)
rename drivers/usb/gadget/{ => function}/u_fs.h (100%)
rename drivers/usb/gadget/{ => function}/u_gether.h (100%)
rename drivers/usb/gadget/{ => function}/u_ncm.h (100%)
rename drivers/usb/gadget/{ => function}/u_phonet.h (100%)
rename drivers/usb/gadget/{ => function}/u_rndis.h (100%)
rename drivers/usb/gadget/{ => function}/u_serial.c (100%)
rename drivers/usb/gadget/{ => function}/u_serial.h (100%)
rename drivers/usb/gadget/{ => function}/u_uac1.c (100%)
rename drivers/usb/gadget/{ => function}/u_uac1.h (97%)
rename drivers/usb/gadget/{ => function}/uvc.h (100%)
rename drivers/usb/gadget/{ => function}/uvc_queue.c (100%)
rename drivers/usb/gadget/{ => function}/uvc_queue.h (100%)
rename drivers/usb/gadget/{ => function}/uvc_v4l2.c (100%)
rename drivers/usb/gadget/{ => function}/uvc_video.c (100%)
create mode 100644 drivers/usb/gadget/legacy/Kconfig
create mode 100644 drivers/usb/gadget/legacy/Makefile
rename drivers/usb/gadget/{ => legacy}/acm_ms.c (98%)
rename drivers/usb/gadget/{ => legacy}/audio.c (96%)
rename drivers/usb/gadget/{ => legacy}/cdc2.c (98%)
rename drivers/usb/gadget/{ => legacy}/dbgp.c (99%)
rename drivers/usb/gadget/{ => legacy}/ether.c (98%)
rename drivers/usb/gadget/{ => legacy}/g_ffs.c (98%)
rename drivers/usb/gadget/{ => legacy}/gmidi.c (98%)
rename drivers/usb/gadget/{ => legacy}/hid.c (99%)
rename drivers/usb/gadget/{ => legacy}/inode.c (100%)
rename drivers/usb/gadget/{ => legacy}/mass_storage.c (99%)
rename drivers/usb/gadget/{ => legacy}/multi.c (98%)
rename drivers/usb/gadget/{ => legacy}/ncm.c (98%)
rename drivers/usb/gadget/{ => legacy}/nokia.c (98%)
rename drivers/usb/gadget/{ => legacy}/printer.c (99%)
rename drivers/usb/gadget/{ => legacy}/serial.c (99%)
rename drivers/usb/gadget/{ => legacy}/tcm_usb_gadget.c (100%)
rename drivers/usb/gadget/{ => legacy}/tcm_usb_gadget.h (100%)
rename drivers/usb/gadget/{ => legacy}/webcam.c (98%)
rename drivers/usb/gadget/{ => legacy}/zero.c (99%)
create mode 100644 drivers/usb/gadget/udc/Kconfig
create mode 100644 drivers/usb/gadget/udc/Makefile
rename drivers/usb/gadget/{ => udc}/amd5536udc.c (100%)
rename drivers/usb/gadget/{ => udc}/amd5536udc.h (100%)
rename drivers/usb/gadget/{ => udc}/at91_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/at91_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/atmel_usba_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/atmel_usba_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/bcm63xx_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/dummy_hcd.c (100%)
rename drivers/usb/gadget/{ => udc}/fotg210-udc.c (100%)
rename drivers/usb/gadget/{ => udc}/fotg210.h (100%)
rename drivers/usb/gadget/{ => udc}/fsl_mxc_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/fsl_qe_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/fsl_qe_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/fsl_udc_core.c (100%)
rename drivers/usb/gadget/{ => udc}/fsl_usb2_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/fusb300_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/fusb300_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/gadget_chips.h (100%)
rename drivers/usb/gadget/{ => udc}/goku_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/goku_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/gr_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/gr_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/lpc32xx_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/m66592-udc.c (100%)
rename drivers/usb/gadget/{ => udc}/m66592-udc.h (100%)
rename drivers/usb/gadget/{ => udc}/mv_u3d.h (100%)
rename drivers/usb/gadget/{ => udc}/mv_u3d_core.c (100%)
rename drivers/usb/gadget/{ => udc}/mv_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/mv_udc_core.c (100%)
rename drivers/usb/gadget/{ => udc}/net2272.c (100%)
rename drivers/usb/gadget/{ => udc}/net2272.h (100%)
rename drivers/usb/gadget/{ => udc}/net2280.c (100%)
rename drivers/usb/gadget/{ => udc}/net2280.h (100%)
rename drivers/usb/gadget/{ => udc}/omap_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/omap_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/pch_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/pxa25x_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/pxa25x_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/pxa27x_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/pxa27x_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/r8a66597-udc.c (100%)
rename drivers/usb/gadget/{ => udc}/r8a66597-udc.h (100%)
rename drivers/usb/gadget/{ => udc}/s3c-hsotg.c (100%)
rename drivers/usb/gadget/{ => udc}/s3c-hsotg.h (100%)
rename drivers/usb/gadget/{ => udc}/s3c-hsudc.c (100%)
rename drivers/usb/gadget/{ => udc}/s3c2410_udc.c (100%)
rename drivers/usb/gadget/{ => udc}/s3c2410_udc.h (100%)
rename drivers/usb/gadget/{ => udc}/udc-core.c (100%)
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
