Re: i.MX6 USB OTG support is broken on linux-next

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 10, 2014 at 09:57:39PM +0800, Li Jun wrote:
> On Sat, May 10, 2014 at 09:18:36PM +0800, Shawn Guo wrote:
> > + Robin and David,
> > 
> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> > index cb8e991..9081757 100644
> > --- a/drivers/usb/core/Kconfig
> > +++ b/drivers/usb/core/Kconfig
> > @@ -65,7 +65,6 @@ config USB_OTG
> >  config USB_OTG_WHITELIST
> >         bool "Rely on OTG Targeted Peripherals List"
> >         depends on USB_OTG || EXPERT
> > -       default y if USB_OTG
> >         help
> >           If you say Y here, the "otg_whitelist.h" file will be used as a
> >           product whitelist, so USB peripherals not listed there will be
> > 
> > Shawn
> As Peter suggested, do not enable OTG_FSM in defconfig since there are very few
> HNP&SRP capable device in market. With OTG_FSM enabled, even USB_OTG_WHITELIST
> is not selected, the OTG port still can't work the same as before if you connect
> a normal usb device to it.

If a device is not HNP/SRP capable then it should not be used on this
device. If we can't detect this during runtime then there should be some
devicetree property for that. Making such decisions during compile time
is not an option in the days of multimachine kernels.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux