Re: [Patch V1 1/2] usb: gadget: zero: Add support for interrupt EP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/30/2014 9:36 PM, Felipe Balbi wrote:
On Fri, Mar 14, 2014 at 11:41:47AM -0400, Alan Stern wrote:
On Fri, 14 Mar 2014, Amit Virdi wrote:

Felipe, Alan,

On 2/25/2014 10:43 AM, Amit Virdi wrote:
ccing: Felipe Balbi, Alen Stern

On 2/24/2014 3:55 PM, Amit VIRDI wrote:
Interrupt endpoints behave quite similar to the bulk endpoints with the
difference that the endpoints expect data sending/reception request at
particular intervals till the whole data has not been transmitted.

The interrupt EP support is added to gadget zero. A new alternate
setting (=2)
has been added. It has 6 endpoints (2-BULK, 2-ISOC, 2-INTERRUPT). The
default
parameters are set as:
          bInterval: 4
          wMaxPacketSize: 1024
However, the same can be overridden through the module parameter
interface.

The code is tested for HS and SS on a platform having DWC3 controller.

Signed-off-by: Amit Virdi <amit.virdi@xxxxxx>

I'm sorry, I simply have not had time to look at either of these
patches.  The basic idea is okay; there's no good reason not to have
testing available for interrupt endpoints.

What happens if you try to run this gadget but the UDC can't provide
more than 4 endpoints?  Would it make more sense to have the new
altsetting provide only the two interrupt endpoints?

makes sense to me.


Thanks Alan and Felipe,

I'll send V2 with modified implementation that would have fewer endpoints - 2 interrupt endpoints apart from the default 2 control EPs - in alternate interface 2.

Regards
Amit Virdi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux