On Mon, Apr 21, 2014 at 11:53:53PM -0500, Felipe Balbi wrote: > Hi, > > On Wed, Mar 05, 2014 at 08:52:24AM +0800, Peter Chen wrote: > > We already have CONFIG_USB_OTG which can cover all CONFIG_USB_OTG_FSM > > does. > > > > Cc: Jun Li <b47624@xxxxxxxxxxxxx> > > Cc: Anton Tikhomirov <av.tikhomirov@xxxxxxxxxxx> > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > > --- > > drivers/usb/phy/Kconfig | 11 +---------- > > drivers/usb/phy/Makefile | 2 +- > > 2 files changed, 2 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig > > index 7d1451d..65e5b68 100644 > > --- a/drivers/usb/phy/Kconfig > > +++ b/drivers/usb/phy/Kconfig > > @@ -6,15 +6,6 @@ menu "USB Physical Layer drivers" > > config USB_PHY > > def_bool n > > > > -config USB_OTG_FSM > > - tristate "USB 2.0 OTG FSM implementation" > > - depends on USB > > - select USB_OTG > > - select USB_PHY > > - help > > - Implements OTG Final State Machine as specified in On-The-Go > > - and Embedded Host Supplement to the USB Revision 2.0 Specification. > > - > > # > > # USB Transceiver Drivers > > # > > @@ -29,7 +20,7 @@ config AB8500_USB > > > > config FSL_USB2_OTG > > bool "Freescale USB OTG Transceiver Driver" > > - depends on USB_EHCI_FSL && USB_FSL_USB2 && USB_OTG_FSM && PM_RUNTIME > > + depends on USB_EHCI_FSL && USB_FSL_USB2 && PM_RUNTIME > > select USB_OTG > > select USB_PHY > > help > > diff --git a/drivers/usb/phy/Makefile b/drivers/usb/phy/Makefile > > index be58ada..3e8f831 100644 > > --- a/drivers/usb/phy/Makefile > > +++ b/drivers/usb/phy/Makefile > > @@ -3,7 +3,7 @@ > > # > > obj-$(CONFIG_USB_PHY) += phy.o > > obj-$(CONFIG_OF) += of.o > > -obj-$(CONFIG_USB_OTG_FSM) += phy-fsm-usb.o > > +obj-$(CONFIG_USB_OTG) += phy-fsm-usb.o > > I'm not sure we should do this, what if people want to use the FSM as a > standalone library ? (we just got chipidea patches for that) > > Also, even if we don't have OTG support, we can still use parts of the > FSM and just ignore HNP and some other OTG-only details. Peter, I just saw you're in Cc for chipidea's FSM patches, have you thought about using FSM without full OTG support ? -- balbi
Attachment:
signature.asc
Description: Digital signature
