On Wed, Apr 16, 2014 at 10:54:26AM -0400, Alan Stern wrote:
> On Tue, 15 Apr 2014, Michael Welling wrote:
>
> > Allows the driver to turn off the clock during suspend for additional power savings.
> >
> > Signed-off-by: Michael Welling <mwelling@xxxxxxxx>
>
> > @@ -181,6 +182,40 @@ static int ehci_atmel_drv_remove(struct platform_device *pdev)
> > return 0;
> > }
> >
> > +#ifdef CONFIG_PM
> > +static int
> > +ehci_atmel_drv_suspend(struct platform_device *pdev, pm_message_t mesg)
> > +{
> > + struct usb_hcd *hcd = platform_get_drvdata(pdev);
> > +
> > + if (device_may_wakeup(&pdev->dev))
> > + enable_irq_wake(hcd->irq);
>
> This is peculiar. Wny isn't the IRQ enabled all the time? As I
> understand it, the proper way to disable wakeups is to tell the
> controller not to issue any wakeup signal at all. Not to tell the
> kernel that the IRQ shouldn't be used for wakeups. That sort of
> approach fails when shared IRQs are used.
I was just following the lead of the at91 ohci driver. I have cc'd
the author of the driver to see if he has an insight as to why the
wake is being turned on and off for the Atmel processors.
After a little feedback I will update the patch as necessary.
>
> Otherwise the patch looks okay.
>
> Alan Stern
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
