On Tuesday, April 15, 2014 6:33 AM, Felipe Balbi wrote:
> On Mon, Apr 14, 2014 at 02:13:34PM -0700, Paul Zimmerman wrote:
> > From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> >
> > Moves the s3c-hsotg driver into the dwc2 directory and uses the
> > dwc2 defines in hw.h. Renames s3c-hsotg.c to gadget.c.
> >
> > NOTE: You can build both host and peripheral as a dynamically
> > linked module, but be aware that if you insmod dwc2_gadget, then
> > rmmod it, then insmod dwc2 and dwc2_platform for host mode, this
> > will not work. As the step to rmmod dwc2_gadget.ko will turn off
> > the clock to the USB IP. The dwc2 host driver currently does not
> > look to turn on a clock yet. A patch to fix that will be coming
> > soon.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> > [ jh,rb - For gadget part only: ]
> > Tested-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > Tested-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> > [ pz: Folded Kconfig/Makefile changes, which were originally in
> > a separate patch, into this one, to avoid a build breakage.
> > Modified Kconfig/Makefile changes a bit. Tested host part only. ]
> > Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>
> > ---
> > drivers/usb/dwc2/Kconfig | 61 +++-
> > drivers/usb/dwc2/Makefile | 37 +-
> > drivers/usb/{gadget/s3c-hsotg.c => dwc2/gadget.c} | 415 +++++++++++-----------
> > drivers/usb/gadget/Kconfig | 6 -
> > drivers/usb/gadget/Makefile | 1 -
> > drivers/usb/gadget/s3c-hsotg.h | 378 --------------------
> > 6 files changed, 273 insertions(+), 625 deletions(-)
> > rename drivers/usb/{gadget/s3c-hsotg.c => dwc2/gadget.c} (91%)
> > delete mode 100644 drivers/usb/gadget/s3c-hsotg.h
> >
> > diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
> > index be947d6..f93807b 100644
> > --- a/drivers/usb/dwc2/Kconfig
> > +++ b/drivers/usb/dwc2/Kconfig
> > @@ -1,25 +1,58 @@
> > config USB_DWC2
> > - tristate "DesignWare USB2 DRD Core Support"
> > + bool "DesignWare USB2 DRD Core Support"
>
> why this change to bool ? Seems unrelated. Other than that, for gadget:
>
> Acked-by: Felipe Balbi <balbi@xxxxxx>
>
> Happy this is not my headache^W^W^Wmoving forward and merging with dwc2
> ;-)
I am also happy. :-)
This is what I have wanted for a long time.
Without everyone's effort, it cannot be possible
to merge it. Thank you!
Best regards,
Jingoo Han
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
