Re: [PATCH v3] u_ether: move hardware transmit to RX workqueue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Apr 02, 2014 at 05:07:28PM +0200, Andrzej Pietrasiewicz wrote:
> W dniu 02.04.2014 16:39, clanlab.proj pisze:
> >Hi Andrzej,
> >
> 
> >My device supports rndis only and the platform was beased on Android.
> >Sorry I cannot test with the behavior like what you've did.
> >Could you provide the board information to me and maybe I can trying to get one?
> 
> It's a board with an s5pc110 chip.
> 
> >Btw, when I tested g_ether gadget by enable/disable from Android UI it looks all fine.
> 
> Are you using it as a loadable module, or compiled-in?
> Does Android UI really control g_ether? Or perhaps it controls android gadget,
> which is a different thing than g_ether? Android gadget is not in mainline kernel.
> 
> >
> >
> >Sorry I cannot test the plug/un-plug behavior for you.
> 
> What I imagine is that you have a (development) board with an ARM and an UDC (OTG) chip,
> and you connect the board to a PC host. So it should be possible to detach the cable
> and attach it again, shouldn't it?
> 
> >I'll try to figure out if it can be fixed or improved by code reviewing.
> 
> It looks like eth_stop should be called somewhere when the gadget is unplugged.
> But as it is now it is called only when g_ether module is unloaded.

well, if we don't get to a resolution for this, we will have to revert
that patch once -rc1 is out.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux