On Fri, 2014-03-28 at 10:56 +0100, Johan Hovold wrote:
> [ +CC: Dan and Bjørn ]
>
> On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> > This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> > Mobile Broadband Card.
>
> Shouldn't this device be handled by the option driver?
>
> In fact, PID 0x8133 for 5720 VZW (which your clean-up patch touches)
> is listed in both option and sierra.
>
> I think we need to revert 1ebca9dad5ab ("USB: serial: add usbid for dell
> wwan card to sierra.c").
Yeah, you're right. The revert should be sufficient since like you say
it's already in option (which is the correct driver for this Novatel
product, which is obviously not a Sierra device).
Dan
> Thanks,
> Johan
>
> > Signed-off-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
> > ---
> > drivers/usb/serial/sierra.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> > index b78fd4e..961d586 100644
> > --- a/drivers/usb/serial/sierra.c
> > +++ b/drivers/usb/serial/sierra.c
> > @@ -292,6 +292,7 @@ static const struct usb_device_id id_table[] = {
> > .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
> > },
> > { USB_DEVICE(0x413C, 0x8133) }, /* Dell Computer Corp. Wireless 5720 VZW Mobile Broadband (EVDO Rev-A) Minicard GPS Port */
> > + { USB_DEVICE(0x413C, 0x81A9) }, /* Dell Computer Corp. Wireless 5808e 4G LTE Mobile Broadband Card */
> >
> > { }
> > };
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
