Re: [PATCH 1/2] USB: serial: fixed the product id typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-03-28 at 15:25 +0800, AceLan Kao wrote:
> Fixed the product id typo and replace whitespace with tab.
> 
> Signed-off-by: AceLan Kao <acelan.kao@xxxxxxxxxxxxx>
> ---
>  drivers/usb/serial/sierra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
> index a9eb622..b78fd4e 100644
> --- a/drivers/usb/serial/sierra.c
> +++ b/drivers/usb/serial/sierra.c
> @@ -291,7 +291,7 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(0x0f3d, 0x68A3), 	/* Airprime/Sierra Wireless Direct IP modems */
>  	  .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
>  	},
> -       { USB_DEVICE(0x413C, 0x08133) }, /* Dell Computer Corp. Wireless 5720 VZW Mobile Broadband (EVDO Rev-A) Minicard GPS Port */
> +	{ USB_DEVICE(0x413C, 0x8133) }, /* Dell Computer Corp. Wireless 5720 VZW Mobile Broadband (EVDO Rev-A) Minicard GPS Port */

The Dell 5720 (Novatel E725) is not a Sierra device, so it should
certainly not remain in the 'sierra' driver and the original commit that
did this was in error.  It's device ID should be moved to the 'option'
driver instead.  So could you resend this patch, but move the device to
option.c and fix the typo there?

Thanks,
Dan

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux