On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote:
> As the module does not use the standard USB mechanism, the appropriate
> product and vendor IDs have to be added.
Should these really be going into usb-serial-simple? If they are indeed
the PPP/Modem interface, then isn't something like 'option' a better
choice? Despite the name, it's the default WWAN serial driver.
While the device probably has a net port that's usually used for data,
I'll be the PPP port can be used for data too, and that should be driven
by something that can achieve reasonable speeds. I'm not sure if it's
still the case, but the generic serial drivers didn't use to have great
buffer management and you could not get near HSDPA or EVDO-A speeds with
them.
Dan
> Signed-off-by: Michael Ulbricht <michael.ulbricht@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/usb/serial/usb-serial-simple.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> index fb79775..b25e552 100644
> --- a/drivers/usb/serial/usb-serial-simple.c
> +++ b/drivers/usb/serial/usb-serial-simple.c
> @@ -61,7 +61,17 @@ DEVICE(vivopay, VIVOPAY_IDS);
> { USB_DEVICE(0x0c44, 0x0022) }, /* unknown Mororola phone */ \
> { USB_DEVICE(0x22b8, 0x2a64) }, /* Motorola KRZR K1m */ \
> { USB_DEVICE(0x22b8, 0x2c84) }, /* Motorola VE240 phone */ \
> - { USB_DEVICE(0x22b8, 0x2c64) } /* Motorola V950 phone */
> + { USB_DEVICE(0x22b8, 0x2c64) }, /* Motorola V950 phone */ \
> + { USB_DEVICE(0x22b8, 0x2d94) }, /* Motorola H24 HSPA module ( Diagnostic ) */ \
> + { USB_DEVICE(0x22b8, 0x2d9B) }, /* Motorola H24 HSPA module ( NMEA) */ \
> + { USB_DEVICE(0x22b8, 0x2d93) }, /* Motorola H24 HSPA module (Modem + AT Port ) */ \
> + { USB_DEVICE(0x22b8, 0x2d92) }, /* Motorola H24 HSPA module (Modem + Diagnostic ) */ \
> + { USB_DEVICE(0x22b8, 0x2d96) }, /* Motorola H24 HSPA module (Modem + NMEA) */ \
> + { USB_DEVICE(0x22b8, 0x2d98) }, /* Motorola H24 HSPA module ( Diagnostic + NMEA) */ \
> + { USB_DEVICE(0x22b8, 0x2d95) }, /* Motorola H24 HSPA module (Modem + AT Port + Diagnostic ) */ \
> + { USB_DEVICE(0x22b8, 0x2d99) }, /* Motorola H24 HSPA module (Modem + AT Port + NMEA) */ \
> + { USB_DEVICE(0x22b8, 0x2d97) }, /* Motorola H24 HSPA module (Modem + Diagnostic + NMEA) */ \
> + { USB_DEVICE(0x22b8, 0x2d9A) } /* Motorola H24 HSPA module (Modem + AT Port + Diagnostic + NMEA) */
> DEVICE(moto_modem, MOTO_IDS);
>
> /* HP4x (48/49) Generic Serial driver */
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
