>> Can you please explain why we need to check if the waitqueue is active? > > and add a comment that answers the above question. Ooooohhhhh.... the braces!!! Well, that's just mean... I expect that we don't really need the waitqueue_active() check there as long as we fix the patch to make sure the control flow in the rest of the statements actually stays the same. (That's why I really like to put comments for an else block next to or under the opening brace, instead of above with another empty line...) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html