I don't know enough about how runtime PM works in this driver to really review that patch, sorry. (Would this do a complete resume of the device if we call usbnet_stop() while it was suspended? Is that what we want?) I think you could have also preserved the original logic of using dev->wait as a flag if you had just replaced 'if (!dev->wait &&' with 'if (!waitqueue_active(&dev->wait) &&' to check whether the waitqueue is empty. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html