Ignore last mail, was not intended for you. > -----Original Message----- > From: Gupta Suresh-B42813 > Sent: Wednesday, March 19, 2014 11:33 PM > To: 'gregkh@xxxxxxxxxxxxxxxxxxx' > Cc: balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in > platform device id > > Hi Ramneek, > > Do you understand, what Greg want to communicate. > > > Thanks > SuresH > > > -----Original Message----- > > From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Wednesday, March 19, 2014 10:22 PM > > To: Gupta Suresh-B42813 > > Cc: balbi@xxxxxx; linux-usb@xxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in > > platform device id > > > > On Wed, Mar 19, 2014 at 02:25:25PM +0000, suresh.gupta@xxxxxxxxxxxxx > > wrote: > > > Hi > > > > > > > -----Original Message----- > > > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > > > Sent: Saturday, March 15, 2014 7:10 AM > > > > To: Gupta Suresh-B42813 > > > > Cc: balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > > > > linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in > > > > platform device id > > > > > > > > On Fri, Mar 14, 2014 at 08:52:19PM +0000, > > > > suresh.gupta@xxxxxxxxxxxxx > > > > wrote: > > > > > Hi, > > > > > Thanks for reviewing my patches. > > > > > Please find my comments inline > > > > > > > > > > -----Original Message----- > > > > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > > > > Sent: Thursday, March 13, 2014 8:56 PM > > > > > To: Gupta Suresh-B42813 > > > > > Cc: balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > > > > > linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Gupta > > > > > Suresh-B42813 > > > > > Subject: Re: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry > > > > > in platform device id > > > > > > > > > > On Thu, Mar 13, 2014 at 07:35:31PM +0530, Suresh Gupta wrote: > > > > > > From: Suresh Gupta <B42813@xxxxxxxxxxxxx> > > > > > > > > > > > > Add FSL USB Gadget entry in platform device id table > > > > > > > > > > why this tab ? > > > > > [SuresH] I will remove it in next version. > > > > > > > > > > > Signed-off-by: Suresh Gupta <B42813@xxxxxxxxxxxxx> > > > > > > --- > > > > > > drivers/usb/gadget/fsl_udc_core.c | 2 ++ > > > > > > 1 file changed, 2 insertions(+) > > > > > > > > > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > > > > > > b/drivers/usb/gadget/fsl_udc_core.c > > > > > > index b7dea4e..35b20e6 100644 > > > > > > --- a/drivers/usb/gadget/fsl_udc_core.c > > > > > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id > > > > fsl_udc_devtype[] = { > > > > > > }, { > > > > > > .name = "imx-udc-mx51", > > > > > > }, { > > > > > > + .name = "fsl-usb2-udc", > > > > > > > > > > why aren't you just using chipidea ? > > > > > [SuresH] This is our legacy driver for all previous and existing > > > > > ppc socs. Many of our customers are already using this, and we > > > > > need to support them on this driver. We do have plans to shift > > > > > to chipidea, but after some time. > > > > > > > > cool, you already have plans, so we will see a new glue layer for > > > > v3.16 right ? Which means I don't need to take this patch either. > > > > > > > we do have plans, but in remote future. Right now, we need to > > > support customers on the present legacy driver. We'll phase out this > > > driver slowly when we integrate chipidea. At this time I would > > > request you to please accept this patch > > > > Even if Felipe takes the patch, I'll reject it as you should be doing > > the correct thing here, and if it's accepted, it will never be > changed... > > > > greg k-h > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
