Re: [PATCH v6 part2 1/8] usb: don't clear FEAT_C_ENABLE on usb_port_runtime_resume failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 Mar 2014, Dan Williams wrote:

> Three reasons:
> 1/ It's an invalid operation on usb3 ports
> 2/ There's no guarantee of when / if a usb2 port has entered an error
>    state relative to PORT_POWER request
> 3/ The port is active / powered at this point, so khubd will clear it as
>    a matter of course
> 
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  drivers/usb/core/port.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
> index 9d9a3bb00f40..96f7a29e2ac6 100644
> --- a/drivers/usb/core/port.c
> +++ b/drivers/usb/core/port.c
> @@ -106,7 +106,6 @@ static int usb_port_runtime_resume(struct device *dev)
>  		if (retval < 0)
>  			dev_dbg(&port_dev->dev, "can't get reconnection after setting port  power on, status %d\n",
>  					retval);
> -		usb_clear_port_feature(hdev, port1, USB_PORT_FEAT_C_ENABLE);
>  		retval = 0;
>  	}

I trust that further changes in this series will prevent the "port N 
disabled by hub (EMI?), re-enabling..." message from being logged.  
Have you tested this?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux